Skip to content

feat: add admin interface for Chemistry Sample Info model#347

Closed
jirhiker wants to merge 1 commit into
stagingfrom
BDMS-437-Add-Admin-Interface-for-Chemistry-SampleInfo
Closed

feat: add admin interface for Chemistry Sample Info model#347
jirhiker wants to merge 1 commit into
stagingfrom
BDMS-437-Add-Admin-Interface-for-Chemistry-SampleInfo

Conversation

@jirhiker

@jirhiker jirhiker commented Jan 8, 2026

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • Expose legacy Chemistry SampleInfo records for admin review and troubleshooting

How

Implementation summary - the following was changed / added / removed:

  • Added ChemistrySampleInfoAdmin view with list, filters, search, and form fields
  • Registered the view in admin setup for the legacy Chemistry SampleInfo model

Notes

Any special considerations, workarounds, or follow-up work to note?

  • This view targets the legacy Chemistry_SampleInfo table and is intended for backfill visibility

@jirhiker jirhiker closed this Jan 8, 2026
@jirhiker jirhiker deleted the BDMS-437-Add-Admin-Interface-for-Chemistry-SampleInfo branch January 8, 2026 00:08

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8efd6f8bce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread admin/views/__init__.py
Comment on lines 33 to +34
from admin.views.sample import SampleAdmin
from admin.views.chemistry_sampleinfo import ChemistrySampleInfoAdmin

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Register the new admin view so it is reachable

The new ChemistrySampleInfoAdmin class is exported here, but create_admin in admin/config.py never imports it or calls admin.add_view(...) for it. As a result, the admin UI will not show the “Chemistry Sample Info” menu and the legacy records are still inaccessible, which contradicts the stated goal of exposing the table. Consider adding the model and view registration in create_admin so the view is actually mounted.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant